1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
|
"""Tests for the SQLAlchemy async database layer."""
import pytest
from decimal import Decimal
from datetime import datetime, timezone
from unittest.mock import AsyncMock, MagicMock, patch
def make_candle():
from shared.models import Candle
return Candle(
symbol="AAPL",
timeframe="1m",
open_time=datetime(2024, 1, 1, tzinfo=timezone.utc),
open=Decimal("50000"),
high=Decimal("51000"),
low=Decimal("49500"),
close=Decimal("50500"),
volume=Decimal("100"),
)
def make_signal():
from shared.models import Signal, OrderSide
return Signal(
id="sig-1",
strategy="ma_cross",
symbol="AAPL",
side=OrderSide.BUY,
price=Decimal("50000"),
quantity=Decimal("0.1"),
reason="Golden cross",
created_at=datetime(2024, 1, 1, tzinfo=timezone.utc),
)
def make_order():
from shared.models import Order, OrderSide, OrderType, OrderStatus
return Order(
id="ord-1",
signal_id="sig-1",
symbol="AAPL",
side=OrderSide.BUY,
type=OrderType.LIMIT,
price=Decimal("50000"),
quantity=Decimal("0.1"),
status=OrderStatus.PENDING,
created_at=datetime(2024, 1, 1, tzinfo=timezone.utc),
)
class TestDatabaseConstructor:
def test_stores_url(self):
from shared.db import Database
db = Database("postgresql://user:pass@localhost/db")
assert db._database_url == "postgresql+asyncpg://user:pass@localhost/db"
def test_converts_url_prefix(self):
from shared.db import Database
db = Database("postgresql://host/db")
assert db._database_url.startswith("postgresql+asyncpg://")
def test_keeps_asyncpg_prefix(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
assert db._database_url == "postgresql+asyncpg://host/db"
def test_get_session_exists(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
assert hasattr(db, "get_session")
class TestDatabaseConnect:
@pytest.mark.asyncio
async def test_connect_creates_engine_and_tables(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_conn = AsyncMock()
mock_cm = AsyncMock()
mock_cm.__aenter__.return_value = mock_conn
mock_engine = MagicMock()
mock_engine.begin.return_value = mock_cm
mock_engine.dispose = AsyncMock()
with patch("shared.db.create_async_engine", return_value=mock_engine) as mock_create:
with patch("shared.db.async_sessionmaker"):
with patch("shared.db.Base") as mock_base:
mock_base.metadata.create_all = MagicMock()
await db.connect()
mock_create.assert_called_once()
@pytest.mark.asyncio
async def test_init_tables_is_alias_for_connect(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_conn = AsyncMock()
mock_cm = AsyncMock()
mock_cm.__aenter__.return_value = mock_conn
mock_engine = MagicMock()
mock_engine.begin.return_value = mock_cm
mock_engine.dispose = AsyncMock()
with patch("shared.db.create_async_engine", return_value=mock_engine):
with patch("shared.db.async_sessionmaker"):
with patch("shared.db.Base") as mock_base:
mock_base.metadata.create_all = MagicMock()
await db.init_tables()
# Should succeed without error (same as connect)
class TestDatabaseClose:
@pytest.mark.asyncio
async def test_close_disposes_engine(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_engine = AsyncMock()
db._engine = mock_engine
await db.close()
mock_engine.dispose.assert_awaited_once()
class TestInsertCandle:
@pytest.mark.asyncio
async def test_insert_candle_uses_merge_and_commit(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.merge = MagicMock(return_value=None)
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
candle = make_candle()
await db.insert_candle(candle)
mock_session.merge.assert_called_once()
mock_session.commit.assert_awaited_once()
class TestInsertSignal:
@pytest.mark.asyncio
async def test_insert_signal_uses_add_and_commit(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.add = MagicMock()
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
signal = make_signal()
await db.insert_signal(signal)
mock_session.add.assert_called_once()
mock_session.commit.assert_awaited_once()
class TestInsertOrder:
@pytest.mark.asyncio
async def test_insert_order_uses_add_and_commit(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.add = MagicMock()
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
order = make_order()
await db.insert_order(order)
mock_session.add.assert_called_once()
mock_session.commit.assert_awaited_once()
class TestUpdateOrderStatus:
@pytest.mark.asyncio
async def test_update_order_status_uses_execute_and_commit(self):
from shared.db import Database
from shared.models import OrderStatus
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
filled = datetime(2024, 1, 2, tzinfo=timezone.utc)
await db.update_order_status("ord-1", OrderStatus.FILLED, filled)
mock_session.execute.assert_awaited_once()
mock_session.commit.assert_awaited_once()
class TestGetCandles:
@pytest.mark.asyncio
async def test_get_candles_returns_list_of_dicts(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
# Create a mock row that behaves like a SA result row
mock_row = MagicMock()
mock_row._mapping = {
"symbol": "AAPL",
"timeframe": "1m",
"open_time": datetime(2024, 1, 1, tzinfo=timezone.utc),
"open": Decimal("50000"),
"high": Decimal("51000"),
"low": Decimal("49500"),
"close": Decimal("50500"),
"volume": Decimal("100"),
}
mock_result = MagicMock()
mock_result.fetchall.return_value = [mock_row]
mock_session = AsyncMock()
mock_session.execute = AsyncMock(return_value=mock_result)
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
result = await db.get_candles("AAPL", "1m", 500)
assert isinstance(result, list)
assert len(result) == 1
assert result[0]["symbol"] == "AAPL"
mock_session.execute.assert_awaited_once()
class TestRollbackOnError:
@pytest.mark.asyncio
async def test_insert_candle_rollback_on_error(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.merge = MagicMock(return_value=None)
mock_session.commit = AsyncMock(side_effect=RuntimeError("db error"))
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
candle = make_candle()
with pytest.raises(RuntimeError, match="db error"):
await db.insert_candle(candle)
mock_session.rollback.assert_awaited_once()
@pytest.mark.asyncio
async def test_insert_signal_rollback_on_error(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.add = MagicMock()
mock_session.commit = AsyncMock(side_effect=RuntimeError("db error"))
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
signal = make_signal()
with pytest.raises(RuntimeError, match="db error"):
await db.insert_signal(signal)
mock_session.rollback.assert_awaited_once()
class TestTransactionContextManager:
@pytest.mark.asyncio
async def test_transaction_context_manager_commits(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.add = MagicMock()
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
async with db.transaction() as session:
session.add(MagicMock())
mock_session.commit.assert_awaited_once()
mock_session.rollback.assert_not_awaited()
@pytest.mark.asyncio
async def test_transaction_context_manager_rollback(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
with pytest.raises(ValueError, match="test error"):
async with db.transaction() as _session:
raise ValueError("test error")
mock_session.rollback.assert_awaited_once()
mock_session.commit.assert_not_awaited()
class TestInsertPortfolioSnapshot:
@pytest.mark.asyncio
async def test_insert_portfolio_snapshot_uses_add_and_commit(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.add = MagicMock()
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
await db.insert_portfolio_snapshot(
total_value=Decimal("10000"),
realized_pnl=Decimal("0"),
unrealized_pnl=Decimal("500"),
)
mock_session.add.assert_called_once()
mock_session.commit.assert_awaited_once()
@pytest.mark.asyncio
async def test_insert_portfolio_snapshot_rollback_on_error(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_session = AsyncMock()
mock_session.add = MagicMock()
mock_session.commit = AsyncMock(side_effect=RuntimeError("db error"))
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
with pytest.raises(RuntimeError, match="db error"):
await db.insert_portfolio_snapshot(
total_value=Decimal("10000"),
realized_pnl=Decimal("0"),
unrealized_pnl=Decimal("500"),
)
mock_session.rollback.assert_awaited_once()
class TestGetPortfolioSnapshots:
@pytest.mark.asyncio
async def test_get_portfolio_snapshots_returns_list_of_dicts(self):
from shared.db import Database
db = Database("postgresql+asyncpg://host/db")
mock_row = MagicMock()
mock_row.total_value = Decimal("10000")
mock_row.realized_pnl = Decimal("0")
mock_row.unrealized_pnl = Decimal("500")
mock_row.snapshot_at = datetime(2024, 1, 1, tzinfo=timezone.utc)
mock_result = MagicMock()
mock_result.scalars.return_value.all.return_value = [mock_row]
mock_session = AsyncMock()
mock_session.execute = AsyncMock(return_value=mock_result)
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
mock_session.__aexit__ = AsyncMock(return_value=False)
db._session_factory = MagicMock(return_value=mock_session)
result = await db.get_portfolio_snapshots(days=30)
assert isinstance(result, list)
assert len(result) == 1
assert result[0]["total_value"] == Decimal("10000")
assert result[0]["unrealized_pnl"] == Decimal("500")
mock_session.execute.assert_awaited_once()
|
