refactor: remove dead code (SentimentData, CircuitBreaker, TradeRow, unused configs)

- Remove SentimentData class and tests (superseded by SentimentAggregator)
- Remove CircuitBreaker, CircuitState, retry_with_backoff and tests (never used)
- Remove TradeRow ORM model and tests (no DB methods reference it)
- Remove unused config fields: circuit_breaker_*, selector_candidates_time, selector_filter_time

3 files changed, 0 insertions, 230 deletions

diff --git a/shared/tests/test_resilience.py b/shared/tests/test_resilience.py
deleted file mode 100644
index e287777..0000000
--- a/shared/tests/test_resilience.py
+++ /dev/null
@@ -1,139 +0,0 @@
-"""Tests for retry with backoff and circuit breaker."""
-
-import time
-
-import pytest
-
-from shared.resilience import CircuitBreaker, CircuitState, retry_with_backoff
-
-
-# ---------------------------------------------------------------------------
-# retry_with_backoff tests
-# ---------------------------------------------------------------------------
-
-
-@pytest.mark.asyncio
-async def test_retry_succeeds_first_try():
-    call_count = 0
-
-    @retry_with_backoff(max_retries=3, base_delay=0.01)
-    async def succeed():
-        nonlocal call_count
-        call_count += 1
-        return "ok"
-
-    result = await succeed()
-    assert result == "ok"
-    assert call_count == 1
-
-
-@pytest.mark.asyncio
-async def test_retry_succeeds_after_failures():
-    call_count = 0
-
-    @retry_with_backoff(max_retries=3, base_delay=0.01)
-    async def flaky():
-        nonlocal call_count
-        call_count += 1
-        if call_count < 3:
-            raise ValueError("not yet")
-        return "recovered"
-
-    result = await flaky()
-    assert result == "recovered"
-    assert call_count == 3
-
-
-@pytest.mark.asyncio
-async def test_retry_raises_after_max_retries():
-    call_count = 0
-
-    @retry_with_backoff(max_retries=3, base_delay=0.01)
-    async def always_fail():
-        nonlocal call_count
-        call_count += 1
-        raise RuntimeError("permanent")
-
-    with pytest.raises(RuntimeError, match="permanent"):
-        await always_fail()
-    # 1 initial + 3 retries = 4 calls
-    assert call_count == 4
-
-
-@pytest.mark.asyncio
-async def test_retry_respects_max_delay():
-    """Backoff should be capped at max_delay."""
-
-    @retry_with_backoff(max_retries=2, base_delay=0.01, max_delay=0.02)
-    async def always_fail():
-        raise RuntimeError("fail")
-
-    start = time.monotonic()
-    with pytest.raises(RuntimeError):
-        await always_fail()
-    elapsed = time.monotonic() - start
-    # With max_delay=0.02 and 2 retries, total delay should be small
-    assert elapsed < 0.5
-
-
-# ---------------------------------------------------------------------------
-# CircuitBreaker tests
-# ---------------------------------------------------------------------------
-
-
-def test_circuit_starts_closed():
-    cb = CircuitBreaker(failure_threshold=3, recovery_timeout=0.05)
-    assert cb.state == CircuitState.CLOSED
-    assert cb.allow_request() is True
-
-
-def test_circuit_opens_after_threshold():
-    cb = CircuitBreaker(failure_threshold=3, recovery_timeout=60.0)
-    for _ in range(3):
-        cb.record_failure()
-    assert cb.state == CircuitState.OPEN
-    assert cb.allow_request() is False
-
-
-def test_circuit_rejects_when_open():
-    cb = CircuitBreaker(failure_threshold=2, recovery_timeout=60.0)
-    cb.record_failure()
-    cb.record_failure()
-    assert cb.state == CircuitState.OPEN
-    assert cb.allow_request() is False
-
-
-def test_circuit_half_open_after_timeout():
-    cb = CircuitBreaker(failure_threshold=2, recovery_timeout=0.05)
-    cb.record_failure()
-    cb.record_failure()
-    assert cb.state == CircuitState.OPEN
-
-    time.sleep(0.06)
-    assert cb.allow_request() is True
-    assert cb.state == CircuitState.HALF_OPEN
-
-
-def test_circuit_closes_on_success():
-    cb = CircuitBreaker(failure_threshold=2, recovery_timeout=0.05)
-    cb.record_failure()
-    cb.record_failure()
-    assert cb.state == CircuitState.OPEN
-
-    time.sleep(0.06)
-    cb.allow_request()  # triggers HALF_OPEN
-    assert cb.state == CircuitState.HALF_OPEN
-
-    cb.record_success()
-    assert cb.state == CircuitState.CLOSED
-    assert cb.allow_request() is True
-
-
-def test_circuit_reopens_on_failure_in_half_open():
-    cb = CircuitBreaker(failure_threshold=2, recovery_timeout=0.05)
-    cb.record_failure()
-    cb.record_failure()
-    time.sleep(0.06)
-    cb.allow_request()  # HALF_OPEN
-    cb.record_failure()
-    assert cb.state == CircuitState.OPEN
diff --git a/shared/tests/test_sa_models.py b/shared/tests/test_sa_models.py
index dc6355e..ae73833 100644
--- a/shared/tests/test_sa_models.py
+++ b/shared/tests/test_sa_models.py
@@ -11,7 +11,6 @@ def test_base_metadata_has_all_tables():
         "candles",
         "signals",
         "orders",
-        "trades",
         "positions",
         "portfolio_snapshots",
         "news_items",
@@ -124,44 +123,6 @@ class TestOrderRow:
         assert fk_cols == {"signal_id": "signals.id"}
 
 
-class TestTradeRow:
-    def test_table_name(self):
-        from shared.sa_models import TradeRow
-
-        assert TradeRow.__tablename__ == "trades"
-
-    def test_columns(self):
-        from shared.sa_models import TradeRow
-
-        mapper = inspect(TradeRow)
-        cols = {c.key for c in mapper.column_attrs}
-        expected = {
-            "id",
-            "order_id",
-            "symbol",
-            "side",
-            "price",
-            "quantity",
-            "fee",
-            "traded_at",
-        }
-        assert expected == cols
-
-    def test_primary_key(self):
-        from shared.sa_models import TradeRow
-
-        mapper = inspect(TradeRow)
-        pk_cols = [c.name for c in mapper.mapper.primary_key]
-        assert pk_cols == ["id"]
-
-    def test_order_id_foreign_key(self):
-        from shared.sa_models import TradeRow
-
-        table = TradeRow.__table__
-        fk_cols = {fk.parent.name: fk.target_fullname for fk in table.foreign_keys}
-        assert fk_cols == {"order_id": "orders.id"}
-
-
 class TestPositionRow:
     def test_table_name(self):
         from shared.sa_models import PositionRow
@@ -233,11 +194,3 @@ class TestStatusDefault:
         status_col = table.c.status
         assert status_col.server_default is not None
         assert status_col.server_default.arg == "PENDING"
-
-    def test_trade_fee_server_default(self):
-        from shared.sa_models import TradeRow
-
-        table = TradeRow.__table__
-        fee_col = table.c.fee
-        assert fee_col.server_default is not None
-        assert fee_col.server_default.arg == "0"
diff --git a/shared/tests/test_sentiment.py b/shared/tests/test_sentiment.py
deleted file mode 100644
index 9bd8ea3..0000000
--- a/shared/tests/test_sentiment.py
+++ /dev/null
@@ -1,44 +0,0 @@
-"""Tests for market sentiment module."""
-
-from shared.sentiment import SentimentData
-
-
-def test_sentiment_should_buy_default_no_data():
-    s = SentimentData()
-    assert s.should_buy is True
-    assert s.should_block is False
-
-
-def test_sentiment_should_buy_low_fear_greed():
-    s = SentimentData(fear_greed_value=15)
-    assert s.should_buy is True
-
-
-def test_sentiment_should_not_buy_on_greed():
-    s = SentimentData(fear_greed_value=75)
-    assert s.should_buy is False
-
-
-def test_sentiment_should_not_buy_negative_news():
-    s = SentimentData(news_sentiment=-0.4)
-    assert s.should_buy is False
-
-
-def test_sentiment_should_buy_positive_news():
-    s = SentimentData(fear_greed_value=50, news_sentiment=0.3)
-    assert s.should_buy is True
-
-
-def test_sentiment_should_block_extreme_greed():
-    s = SentimentData(fear_greed_value=85)
-    assert s.should_block is True
-
-
-def test_sentiment_should_block_very_negative_news():
-    s = SentimentData(news_sentiment=-0.6)
-    assert s.should_block is True
-
-
-def test_sentiment_no_block_on_neutral():
-    s = SentimentData(fear_greed_value=50, news_sentiment=0.0)
-    assert s.should_block is False