feat: add config validation, SecretStr for secrets, API security fields

7 files changed, 26 insertions, 26 deletions

diff --git a/services/api/src/trading_api/main.py b/services/api/src/trading_api/main.py
index 39f7b43..87306b2 100644
--- a/services/api/src/trading_api/main.py
+++ b/services/api/src/trading_api/main.py
@@ -13,7 +13,7 @@ from trading_api.routers import portfolio, orders, strategies
 @asynccontextmanager
 async def lifespan(app: FastAPI):
     settings = Settings()
-    app.state.db = Database(settings.database_url)
+    app.state.db = Database(settings.database_url.get_secret_value())
     await app.state.db.connect()
     yield
     await app.state.db.close()
diff --git a/services/backtester/src/backtester/main.py b/services/backtester/src/backtester/main.py
index a4cea76..084ce02 100644
--- a/services/backtester/src/backtester/main.py
+++ b/services/backtester/src/backtester/main.py
@@ -45,7 +45,7 @@ async def run_backtest() -> str:
     except Exception as exc:
         raise RuntimeError(f"Failed to load strategy '{config.strategy_name}': {exc}") from exc
 
-    db = Database(config.database_url)
+    db = Database(config.database_url.get_secret_value())
     await db.connect()
     try:
         rows = await db.get_candles(config.symbol, config.timeframe, config.candle_limit)
diff --git a/services/data-collector/src/data_collector/main.py b/services/data-collector/src/data_collector/main.py
index b42b34c..608d6cd 100644
--- a/services/data-collector/src/data_collector/main.py
+++ b/services/data-collector/src/data_collector/main.py
@@ -56,18 +56,18 @@ async def run() -> None:
     metrics = ServiceMetrics("data_collector")
 
     notifier = TelegramNotifier(
-        bot_token=config.telegram_bot_token,
+        bot_token=config.telegram_bot_token.get_secret_value(),
         chat_id=config.telegram_chat_id,
     )
 
-    db = Database(config.database_url)
+    db = Database(config.database_url.get_secret_value())
     await db.connect()
 
-    broker = RedisBroker(config.redis_url)
+    broker = RedisBroker(config.redis_url.get_secret_value())
 
     alpaca = AlpacaClient(
-        api_key=config.alpaca_api_key,
-        api_secret=config.alpaca_api_secret,
+        api_key=config.alpaca_api_key.get_secret_value(),
+        api_secret=config.alpaca_api_secret.get_secret_value(),
         paper=config.alpaca_paper,
     )
 
diff --git a/services/news-collector/src/news_collector/main.py b/services/news-collector/src/news_collector/main.py
index 3493f7c..f56914f 100644
--- a/services/news-collector/src/news_collector/main.py
+++ b/services/news-collector/src/news_collector/main.py
@@ -115,14 +115,14 @@ async def run() -> None:
     metrics = ServiceMetrics("news_collector")
 
     notifier = TelegramNotifier(
-        bot_token=config.telegram_bot_token,
+        bot_token=config.telegram_bot_token.get_secret_value(),
         chat_id=config.telegram_chat_id,
     )
 
-    db = Database(config.database_url)
+    db = Database(config.database_url.get_secret_value())
     await db.connect()
 
-    broker = RedisBroker(config.redis_url)
+    broker = RedisBroker(config.redis_url.get_secret_value())
 
     health = HealthCheckServer(
         "news-collector",
@@ -133,7 +133,7 @@ async def run() -> None:
     metrics.service_up.labels(service="news-collector").set(1)
 
     # Build collectors
-    finnhub = FinnhubCollector(api_key=config.finnhub_api_key)
+    finnhub = FinnhubCollector(api_key=config.finnhub_api_key.get_secret_value())
     rss = RSSCollector()
     sec = SecEdgarCollector()
     truth = TruthSocialCollector()
diff --git a/services/order-executor/src/order_executor/main.py b/services/order-executor/src/order_executor/main.py
index 51ab286..1d167ef 100644
--- a/services/order-executor/src/order_executor/main.py
+++ b/services/order-executor/src/order_executor/main.py
@@ -26,18 +26,18 @@ async def run() -> None:
     metrics = ServiceMetrics("order_executor")
 
     notifier = TelegramNotifier(
-        bot_token=config.telegram_bot_token,
+        bot_token=config.telegram_bot_token.get_secret_value(),
         chat_id=config.telegram_chat_id,
     )
 
-    db = Database(config.database_url)
+    db = Database(config.database_url.get_secret_value())
     await db.connect()
 
-    broker = RedisBroker(config.redis_url)
+    broker = RedisBroker(config.redis_url.get_secret_value())
 
     alpaca = AlpacaClient(
-        api_key=config.alpaca_api_key,
-        api_secret=config.alpaca_api_secret,
+        api_key=config.alpaca_api_key.get_secret_value(),
+        api_secret=config.alpaca_api_secret.get_secret_value(),
         paper=config.alpaca_paper,
     )
 
diff --git a/services/portfolio-manager/src/portfolio_manager/main.py b/services/portfolio-manager/src/portfolio_manager/main.py
index a6823ae..0214099 100644
--- a/services/portfolio-manager/src/portfolio_manager/main.py
+++ b/services/portfolio-manager/src/portfolio_manager/main.py
@@ -61,10 +61,10 @@ async def run() -> None:
     log = setup_logging("portfolio-manager", config.log_level, config.log_format)
     metrics = ServiceMetrics("portfolio_manager")
     notifier = TelegramNotifier(
-        bot_token=config.telegram_bot_token, chat_id=config.telegram_chat_id
+        bot_token=config.telegram_bot_token.get_secret_value(), chat_id=config.telegram_chat_id
     )
 
-    broker = RedisBroker(config.redis_url)
+    broker = RedisBroker(config.redis_url.get_secret_value())
     tracker = PortfolioTracker()
 
     health = HealthCheckServer(
@@ -76,7 +76,7 @@ async def run() -> None:
     await health.start()
     metrics.service_up.labels(service="portfolio-manager").set(1)
 
-    db = Database(config.database_url)
+    db = Database(config.database_url.get_secret_value())
     await db.connect()
 
     snapshot_task = asyncio.create_task(
diff --git a/services/strategy-engine/src/strategy_engine/main.py b/services/strategy-engine/src/strategy_engine/main.py
index 5a30766..2635b7c 100644
--- a/services/strategy-engine/src/strategy_engine/main.py
+++ b/services/strategy-engine/src/strategy_engine/main.py
@@ -76,18 +76,18 @@ async def run() -> None:
     metrics = ServiceMetrics("strategy_engine")
 
     notifier = TelegramNotifier(
-        bot_token=config.telegram_bot_token,
+        bot_token=config.telegram_bot_token.get_secret_value(),
         chat_id=config.telegram_chat_id,
     )
 
-    broker = RedisBroker(config.redis_url)
+    broker = RedisBroker(config.redis_url.get_secret_value())
 
-    db = Database(config.database_url)
+    db = Database(config.database_url.get_secret_value())
     await db.connect()
 
     alpaca = AlpacaClient(
-        api_key=config.alpaca_api_key,
-        api_secret=config.alpaca_api_secret,
+        api_key=config.alpaca_api_key.get_secret_value(),
+        api_secret=config.alpaca_api_secret.get_secret_value(),
         paper=config.alpaca_paper,
     )
 
@@ -117,12 +117,12 @@ async def run() -> None:
             task = asyncio.create_task(process_symbol(engine, stream, log))
             tasks.append(task)
 
-        if config.anthropic_api_key:
+        if config.anthropic_api_key.get_secret_value():
             selector = StockSelector(
                 db=db,
                 broker=broker,
                 alpaca=alpaca,
-                anthropic_api_key=config.anthropic_api_key,
+                anthropic_api_key=config.anthropic_api_key.get_secret_value(),
                 anthropic_model=config.anthropic_model,
                 max_picks=config.selector_max_picks,
             )