summaryrefslogtreecommitdiff
path: root/services
diff options
context:
space:
mode:
authorTheSiahxyz <164138827+TheSiahxyz@users.noreply.github.com>2026-04-02 16:02:59 +0900
committerTheSiahxyz <164138827+TheSiahxyz@users.noreply.github.com>2026-04-02 16:02:59 +0900
commitc0496919e91f110aeed7bc47b24ebc3b8348ee81 (patch)
tree01325253c4408a8637098161791f06b2f2a5b726 /services
parentbf4afbc0a3cc4e847ef01840365fd6a6ae9c142f (diff)
fix: remove SecretStr field overrides in service subclass configs
StrategyConfig and NewsCollectorConfig redefined anthropic_api_key and finnhub_api_key as plain str, shadowing the parent SecretStr type. This caused AttributeError at runtime when .get_secret_value() was called. The fields are already inherited from Settings — no need to redeclare.
Diffstat (limited to 'services')
-rw-r--r--services/news-collector/src/news_collector/config.py3
-rw-r--r--services/strategy-engine/src/strategy_engine/config.py4
2 files changed, 0 insertions, 7 deletions
diff --git a/services/news-collector/src/news_collector/config.py b/services/news-collector/src/news_collector/config.py
index 70d98f1..6e78eba 100644
--- a/services/news-collector/src/news_collector/config.py
+++ b/services/news-collector/src/news_collector/config.py
@@ -5,6 +5,3 @@ from shared.config import Settings
class NewsCollectorConfig(Settings):
health_port: int = 8084
- finnhub_api_key: str = ""
- news_poll_interval: int = 300
- sentiment_aggregate_interval: int = 900
diff --git a/services/strategy-engine/src/strategy_engine/config.py b/services/strategy-engine/src/strategy_engine/config.py
index 15f8588..9fd9c49 100644
--- a/services/strategy-engine/src/strategy_engine/config.py
+++ b/services/strategy-engine/src/strategy_engine/config.py
@@ -7,7 +7,3 @@ class StrategyConfig(Settings):
symbols: list[str] = ["AAPL", "MSFT", "GOOGL", "AMZN", "TSLA"]
timeframes: list[str] = ["1m"]
strategy_params: dict = {}
- selector_final_time: str = "15:30"
- selector_max_picks: int = 3
- anthropic_api_key: str = ""
- anthropic_model: str = "claude-sonnet-4-20250514"