feat: implement Finnhub news collector with VADER sentiment

1 files changed, 68 insertions, 0 deletions

diff --git a/services/news-collector/tests/test_finnhub.py b/services/news-collector/tests/test_finnhub.py
new file mode 100644
index 0000000..74bd5e6
--- /dev/null
+++ b/services/news-collector/tests/test_finnhub.py
@@ -0,0 +1,68 @@
+"""Tests for Finnhub news collector."""
+
+import pytest
+from unittest.mock import AsyncMock, patch
+from datetime import datetime, timezone
+
+from news_collector.collectors.finnhub import FinnhubCollector
+
+
+@pytest.fixture
+def collector():
+    return FinnhubCollector(api_key="test_key")
+
+
+def test_collector_name(collector):
+    assert collector.name == "finnhub"
+    assert collector.poll_interval == 300
+
+
+async def test_is_available_with_key(collector):
+    assert await collector.is_available() is True
+
+
+async def test_is_available_without_key():
+    c = FinnhubCollector(api_key="")
+    assert await c.is_available() is False
+
+
+async def test_collect_parses_response(collector):
+    mock_response = [
+        {
+            "category": "top news",
+            "datetime": 1711929600,
+            "headline": "AAPL beats earnings",
+            "id": 12345,
+            "related": "AAPL",
+            "source": "MarketWatch",
+            "summary": "Apple reported better than expected...",
+            "url": "https://example.com/article",
+        },
+        {
+            "category": "top news",
+            "datetime": 1711929000,
+            "headline": "Fed holds rates steady",
+            "id": 12346,
+            "related": "",
+            "source": "Reuters",
+            "summary": "The Federal Reserve...",
+            "url": "https://example.com/fed",
+        },
+    ]
+
+    with patch.object(collector, "_fetch_news", new_callable=AsyncMock, return_value=mock_response):
+        items = await collector.collect()
+
+    assert len(items) == 2
+    assert items[0].source == "finnhub"
+    assert items[0].headline == "AAPL beats earnings"
+    assert items[0].symbols == ["AAPL"]
+    assert items[0].url == "https://example.com/article"
+    assert isinstance(items[0].sentiment, float)
+    assert items[1].symbols == []
+
+
+async def test_collect_handles_empty_response(collector):
+    with patch.object(collector, "_fetch_news", new_callable=AsyncMock, return_value=[]):
+        items = await collector.collect()
+    assert items == []