From 4747400168279c6cfc1196d86ec77b5d7b513c61 Mon Sep 17 00:00:00 2001
From: TheSiahxyz <164138827+TheSiahxyz@users.noreply.github.com>
Date: Thu, 2 Apr 2026 16:05:19 +0900
Subject: fix: add TradeRow ORM model, SignalRow missing columns, guard
 Event.from_dict

- Add TradeRow ORM model matching existing trades migration table
- Add conviction, stop_loss, take_profit columns to SignalRow + migration 004
- Persist conviction/stop_loss/take_profit in insert_signal()
- Guard Event.from_dict against malformed data with ValueError instead of KeyError
---
 shared/tests/test_sa_models.py | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'shared/tests')

diff --git a/shared/tests/test_sa_models.py b/shared/tests/test_sa_models.py
index ae73833..c9311dd 100644
--- a/shared/tests/test_sa_models.py
+++ b/shared/tests/test_sa_models.py
@@ -11,6 +11,7 @@ def test_base_metadata_has_all_tables():
         "candles",
         "signals",
         "orders",
+        "trades",
         "positions",
         "portfolio_snapshots",
         "news_items",
@@ -71,6 +72,9 @@ class TestSignalRow:
             "price",
             "quantity",
             "reason",
+            "conviction",
+            "stop_loss",
+            "take_profit",
             "created_at",
         }
         assert expected == cols
-- 
cgit v1.2.3