From 100aa624ad3f8ad466a95f9da8af30f31f77cc9c Mon Sep 17 00:00:00 2001
From: TheSiahxyz <164138827+TheSiahxyz@users.noreply.github.com>
Date: Wed, 1 Apr 2026 16:24:30 +0900
Subject: fix: resolve lint issues and final integration fixes

- Fix ambiguous variable name in binance_rest.py
- Remove unused volumes variable in volume_profile_strategy.py
- Fix import ordering in backtester main.py and test_metrics.py
- Auto-format all files with ruff
---
 services/strategy-engine/src/strategy_engine/config.py        | 1 +
 services/strategy-engine/src/strategy_engine/engine.py        | 5 ++---
 services/strategy-engine/src/strategy_engine/main.py          | 9 +++++++--
 services/strategy-engine/src/strategy_engine/plugin_loader.py | 7 ++-----
 4 files changed, 12 insertions(+), 10 deletions(-)

(limited to 'services/strategy-engine/src')

diff --git a/services/strategy-engine/src/strategy_engine/config.py b/services/strategy-engine/src/strategy_engine/config.py
index 2864b09..e3a49c2 100644
--- a/services/strategy-engine/src/strategy_engine/config.py
+++ b/services/strategy-engine/src/strategy_engine/config.py
@@ -1,4 +1,5 @@
 """Strategy Engine configuration."""
+
 from shared.config import Settings
 
 
diff --git a/services/strategy-engine/src/strategy_engine/engine.py b/services/strategy-engine/src/strategy_engine/engine.py
index 09dbf65..d401aee 100644
--- a/services/strategy-engine/src/strategy_engine/engine.py
+++ b/services/strategy-engine/src/strategy_engine/engine.py
@@ -1,4 +1,5 @@
 """Strategy Engine: consumes candle events and publishes signals."""
+
 import logging
 
 from shared.broker import RedisBroker
@@ -36,9 +37,7 @@ class StrategyEngine:
                 try:
                     signal = strategy.on_candle(candle)
                 except Exception as exc:
-                    logger.error(
-                        "Strategy %s raised on candle: %s", strategy.name, exc
-                    )
+                    logger.error("Strategy %s raised on candle: %s", strategy.name, exc)
                     continue
 
                 if signal is not None:
diff --git a/services/strategy-engine/src/strategy_engine/main.py b/services/strategy-engine/src/strategy_engine/main.py
index 2e3c4ac..53681d1 100644
--- a/services/strategy-engine/src/strategy_engine/main.py
+++ b/services/strategy-engine/src/strategy_engine/main.py
@@ -1,4 +1,5 @@
 """Strategy Engine Service entry point."""
+
 import asyncio
 from pathlib import Path
 
@@ -20,7 +21,9 @@ async def run() -> None:
     config = StrategyConfig()
     log = setup_logging("strategy-engine", config.log_level, config.log_format)
     metrics = ServiceMetrics("strategy_engine")
-    notifier = TelegramNotifier(bot_token=config.telegram_bot_token, chat_id=config.telegram_chat_id)
+    notifier = TelegramNotifier(
+        bot_token=config.telegram_bot_token, chat_id=config.telegram_chat_id
+    )
 
     broker = RedisBroker(config.redis_url)
 
@@ -53,7 +56,9 @@ async def run() -> None:
 
             while True:
                 last_id = await engine.process_once(stream, last_id)
-                metrics.events_processed.labels(service="strategy-engine", event_type="candle").inc()
+                metrics.events_processed.labels(
+                    service="strategy-engine", event_type="candle"
+                ).inc()
     except Exception as exc:
         log.error("fatal_error", error=str(exc))
         await notifier.send_error(str(exc), "strategy-engine")
diff --git a/services/strategy-engine/src/strategy_engine/plugin_loader.py b/services/strategy-engine/src/strategy_engine/plugin_loader.py
index f99b670..62e4160 100644
--- a/services/strategy-engine/src/strategy_engine/plugin_loader.py
+++ b/services/strategy-engine/src/strategy_engine/plugin_loader.py
@@ -1,4 +1,5 @@
 """Dynamic plugin loader for strategy modules."""
+
 import importlib.util
 import sys
 from pathlib import Path
@@ -29,11 +30,7 @@ def load_strategies(strategies_dir: Path) -> list[BaseStrategy]:
 
         for attr_name in dir(module):
             obj = getattr(module, attr_name)
-            if (
-                isinstance(obj, type)
-                and issubclass(obj, BaseStrategy)
-                and obj is not BaseStrategy
-            ):
+            if isinstance(obj, type) and issubclass(obj, BaseStrategy) and obj is not BaseStrategy:
                 instance = obj()
                 yaml_path = config_dir / f"{path.stem}.yaml"
                 if yaml_path.exists():
-- 
cgit v1.2.3