From a65575124b18f2ec5d418623e22c5bdef6c3424e Mon Sep 17 00:00:00 2001
From: TheSiahxyz <164138827+TheSiahxyz@users.noreply.github.com>
Date: Wed, 1 Apr 2026 17:55:44 +0900
Subject: feat(portfolio): track realized PnL on sell orders

---
 services/portfolio-manager/tests/test_portfolio.py | 66 ++++++++++++++++++++++
 services/portfolio-manager/tests/test_snapshot.py  |  4 +-
 2 files changed, 69 insertions(+), 1 deletion(-)

(limited to 'services/portfolio-manager/tests')

diff --git a/services/portfolio-manager/tests/test_portfolio.py b/services/portfolio-manager/tests/test_portfolio.py
index 92ff6ca..5a7ac64 100644
--- a/services/portfolio-manager/tests/test_portfolio.py
+++ b/services/portfolio-manager/tests/test_portfolio.py
@@ -56,3 +56,69 @@ def test_portfolio_no_position_returns_none() -> None:
     tracker = PortfolioTracker()
     position = tracker.get_position("ETH/USDT")
     assert position is None
+
+
+def test_realized_pnl_on_sell() -> None:
+    """Selling should track realized PnL."""
+    tracker = PortfolioTracker()
+
+    # Buy at 50000
+    tracker.apply_order(Order(
+        signal_id="s1", symbol="BTCUSDT", side=OrderSide.BUY,
+        type=OrderType.MARKET, price=Decimal("50000"),
+        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
+    ))
+    assert tracker.realized_pnl == Decimal("0")
+
+    # Sell at 55000 — profit of 500
+    tracker.apply_order(Order(
+        signal_id="s2", symbol="BTCUSDT", side=OrderSide.SELL,
+        type=OrderType.MARKET, price=Decimal("55000"),
+        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
+    ))
+    assert tracker.realized_pnl == Decimal("500")
+
+
+def test_realized_pnl_on_loss() -> None:
+    """Selling at a loss should track negative realized PnL."""
+    tracker = PortfolioTracker()
+
+    tracker.apply_order(Order(
+        signal_id="s1", symbol="BTCUSDT", side=OrderSide.BUY,
+        type=OrderType.MARKET, price=Decimal("50000"),
+        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
+    ))
+    tracker.apply_order(Order(
+        signal_id="s2", symbol="BTCUSDT", side=OrderSide.SELL,
+        type=OrderType.MARKET, price=Decimal("45000"),
+        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
+    ))
+    assert tracker.realized_pnl == Decimal("-500")
+
+
+def test_realized_pnl_accumulates() -> None:
+    """Multiple sells accumulate realized PnL."""
+    tracker = PortfolioTracker()
+
+    # Buy 0.2 at 50000
+    tracker.apply_order(Order(
+        signal_id="s1", symbol="BTCUSDT", side=OrderSide.BUY,
+        type=OrderType.MARKET, price=Decimal("50000"),
+        quantity=Decimal("0.2"), status=OrderStatus.FILLED,
+    ))
+
+    # Sell 0.1 at 55000 -> +500
+    tracker.apply_order(Order(
+        signal_id="s2", symbol="BTCUSDT", side=OrderSide.SELL,
+        type=OrderType.MARKET, price=Decimal("55000"),
+        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
+    ))
+
+    # Sell 0.1 at 60000 -> +1000
+    tracker.apply_order(Order(
+        signal_id="s3", symbol="BTCUSDT", side=OrderSide.SELL,
+        type=OrderType.MARKET, price=Decimal("60000"),
+        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
+    ))
+
+    assert tracker.realized_pnl == Decimal("1500")
diff --git a/services/portfolio-manager/tests/test_snapshot.py b/services/portfolio-manager/tests/test_snapshot.py
index 89d23d7..a464599 100644
--- a/services/portfolio-manager/tests/test_snapshot.py
+++ b/services/portfolio-manager/tests/test_snapshot.py
@@ -21,6 +21,7 @@ class TestSaveSnapshot:
 
         tracker = MagicMock()
         tracker.get_all_positions.return_value = [pos]
+        tracker.realized_pnl = Decimal("500")
 
         db = AsyncMock()
         notifier = AsyncMock()
@@ -33,7 +34,7 @@ class TestSaveSnapshot:
 
         db.insert_portfolio_snapshot.assert_awaited_once_with(
             total_value=expected_total,
-            realized_pnl=Decimal("0"),
+            realized_pnl=Decimal("500"),
             unrealized_pnl=expected_unrealized,
         )
         notifier.send_daily_summary.assert_awaited_once_with(
@@ -51,6 +52,7 @@ class TestSaveSnapshot:
 
         tracker = MagicMock()
         tracker.get_all_positions.return_value = []
+        tracker.realized_pnl = Decimal("0")
 
         db = AsyncMock()
         notifier = AsyncMock()
-- 
cgit v1.2.3