From 61b2a193e79d74783bb1ad4c3a8ccb6ead0f24c0 Mon Sep 17 00:00:00 2001
From: TheSiahxyz <164138827+TheSiahxyz@users.noreply.github.com>
Date: Wed, 1 Apr 2026 17:57:43 +0900
Subject: fix: lint cleanup after medium priority tasks

---
 services/portfolio-manager/tests/test_portfolio.py | 112 ++++++++++++++-------
 1 file changed, 77 insertions(+), 35 deletions(-)

(limited to 'services/portfolio-manager/tests')

diff --git a/services/portfolio-manager/tests/test_portfolio.py b/services/portfolio-manager/tests/test_portfolio.py
index 5a7ac64..768e071 100644
--- a/services/portfolio-manager/tests/test_portfolio.py
+++ b/services/portfolio-manager/tests/test_portfolio.py
@@ -63,19 +63,31 @@ def test_realized_pnl_on_sell() -> None:
     tracker = PortfolioTracker()
 
     # Buy at 50000
-    tracker.apply_order(Order(
-        signal_id="s1", symbol="BTCUSDT", side=OrderSide.BUY,
-        type=OrderType.MARKET, price=Decimal("50000"),
-        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
-    ))
+    tracker.apply_order(
+        Order(
+            signal_id="s1",
+            symbol="BTCUSDT",
+            side=OrderSide.BUY,
+            type=OrderType.MARKET,
+            price=Decimal("50000"),
+            quantity=Decimal("0.1"),
+            status=OrderStatus.FILLED,
+        )
+    )
     assert tracker.realized_pnl == Decimal("0")
 
     # Sell at 55000 — profit of 500
-    tracker.apply_order(Order(
-        signal_id="s2", symbol="BTCUSDT", side=OrderSide.SELL,
-        type=OrderType.MARKET, price=Decimal("55000"),
-        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
-    ))
+    tracker.apply_order(
+        Order(
+            signal_id="s2",
+            symbol="BTCUSDT",
+            side=OrderSide.SELL,
+            type=OrderType.MARKET,
+            price=Decimal("55000"),
+            quantity=Decimal("0.1"),
+            status=OrderStatus.FILLED,
+        )
+    )
     assert tracker.realized_pnl == Decimal("500")
 
 
@@ -83,16 +95,28 @@ def test_realized_pnl_on_loss() -> None:
     """Selling at a loss should track negative realized PnL."""
     tracker = PortfolioTracker()
 
-    tracker.apply_order(Order(
-        signal_id="s1", symbol="BTCUSDT", side=OrderSide.BUY,
-        type=OrderType.MARKET, price=Decimal("50000"),
-        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
-    ))
-    tracker.apply_order(Order(
-        signal_id="s2", symbol="BTCUSDT", side=OrderSide.SELL,
-        type=OrderType.MARKET, price=Decimal("45000"),
-        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
-    ))
+    tracker.apply_order(
+        Order(
+            signal_id="s1",
+            symbol="BTCUSDT",
+            side=OrderSide.BUY,
+            type=OrderType.MARKET,
+            price=Decimal("50000"),
+            quantity=Decimal("0.1"),
+            status=OrderStatus.FILLED,
+        )
+    )
+    tracker.apply_order(
+        Order(
+            signal_id="s2",
+            symbol="BTCUSDT",
+            side=OrderSide.SELL,
+            type=OrderType.MARKET,
+            price=Decimal("45000"),
+            quantity=Decimal("0.1"),
+            status=OrderStatus.FILLED,
+        )
+    )
     assert tracker.realized_pnl == Decimal("-500")
 
 
@@ -101,24 +125,42 @@ def test_realized_pnl_accumulates() -> None:
     tracker = PortfolioTracker()
 
     # Buy 0.2 at 50000
-    tracker.apply_order(Order(
-        signal_id="s1", symbol="BTCUSDT", side=OrderSide.BUY,
-        type=OrderType.MARKET, price=Decimal("50000"),
-        quantity=Decimal("0.2"), status=OrderStatus.FILLED,
-    ))
+    tracker.apply_order(
+        Order(
+            signal_id="s1",
+            symbol="BTCUSDT",
+            side=OrderSide.BUY,
+            type=OrderType.MARKET,
+            price=Decimal("50000"),
+            quantity=Decimal("0.2"),
+            status=OrderStatus.FILLED,
+        )
+    )
 
     # Sell 0.1 at 55000 -> +500
-    tracker.apply_order(Order(
-        signal_id="s2", symbol="BTCUSDT", side=OrderSide.SELL,
-        type=OrderType.MARKET, price=Decimal("55000"),
-        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
-    ))
+    tracker.apply_order(
+        Order(
+            signal_id="s2",
+            symbol="BTCUSDT",
+            side=OrderSide.SELL,
+            type=OrderType.MARKET,
+            price=Decimal("55000"),
+            quantity=Decimal("0.1"),
+            status=OrderStatus.FILLED,
+        )
+    )
 
     # Sell 0.1 at 60000 -> +1000
-    tracker.apply_order(Order(
-        signal_id="s3", symbol="BTCUSDT", side=OrderSide.SELL,
-        type=OrderType.MARKET, price=Decimal("60000"),
-        quantity=Decimal("0.1"), status=OrderStatus.FILLED,
-    ))
+    tracker.apply_order(
+        Order(
+            signal_id="s3",
+            symbol="BTCUSDT",
+            side=OrderSide.SELL,
+            type=OrderType.MARKET,
+            price=Decimal("60000"),
+            quantity=Decimal("0.1"),
+            status=OrderStatus.FILLED,
+        )
+    )
 
     assert tracker.realized_pnl == Decimal("1500")
-- 
cgit v1.2.3